Open
Conversation
… Prateek Change spiFlash.cpp startUp function to return a boolean indicating success or failure.
Contributor
|
Need to have the code hardware tested before I can allow this to be merged into main. |
.vscode/c_cpp_properties.json
Outdated
Contributor
There was a problem hiding this comment.
Remove this file (I apologize for adding it)
prateekgupta5
requested changes
Feb 12, 2026
Contributor
prateekgupta5
left a comment
prateekgupta5
left a comment
There was a problem hiding this comment.
Just remove some files, I can do it ig lol
Contributor
There was a problem hiding this comment.
Move to blaze-lite/core/test
Updated spiFlash constructor to use default parameters for buffer sizes.
Refactor spiFlash constructor and methods for clarity and not using cin/cout when not applicable. Remove unused CS_PIN parameter and commented-out error handling. --Prateek
… remove CS_PIN usage and flash_config.h
prateekgupta5
requested changes
Feb 12, 2026
Contributor
prateekgupta5
left a comment
prateekgupta5
left a comment
There was a problem hiding this comment.
OK can someone review all the minor changes i did cause its late and can someone also move the spiFlashTester.cpp file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the tester file for SPI flash
Description
I made a SPIFlashTester.cpp and made the SPIFlash.h file be alphabetically organized.
Motivation and Context
This creates a tester file
How has this been tested?
Making sure that the functions run
Screenshots (if appropriate):
Types of changes
Checklist: